Configurable resource prefetching #70
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--no-prefetch will directly use `load(...)` instead of just injecting the script sources which makes it easier to navigate and investigate profiles. - Support more complex command line args and flags - Add --help to cli.js Bug: 411303884 Change-Id: I43a032342a6da42bfb61ebd9415e62f9d9597ecc Reviewed-on: https://chromium-review.googlesource.com/c/external/github.com/WebKit/JetStream/+/6468518 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org>
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
camillobruni
changed the title
camillobruni
changed the title
kmiller68
reviewed
May 14, 2025
| for (const test of testPlans) | ||
| print(" ", test.name) | ||
| } else { | ||
| print("Running tests: " + testList) |
There was a problem hiding this comment.
Can we not print this? I often run the cli with jsc -e 'dumpJSONResults = true' cli.js > results.json and this print would break that.
Comment on lines
+812
to
+815
| if (globalThis.prefetchResources) | ||
| addScriptWithURL(cache[file].blobURL); | ||
| else | ||
| addScriptWithURL(file); |
There was a problem hiding this comment.
Nit: I would just make this addScriptWithURL(globalThis.prefetchResources ? cache[file].blobURL : file);
| @@ -23,25 +23,47 @@ | |||
| * THE POSSIBILITY OF SUCH DAMAGE. | |||
| */ | |||
|
|
|||
| globalThis.prefetchResources = true; | |||
| @@ -36,7 +36,9 @@ | |||
| const isInBrowser = true; | |||
| const isD8 = false; | |||
| const isSpiderMonkey = false; | |||
| globalThis.prefetchResources = true; | |||
| @@ -62,8 +70,12 @@ if (typeof(URLSearchParams) !== "undefined") { | |||
| customTestList = urlParameters.getAll("test"); | |||
| globalThis.testIterationCount = getIntParam(urlParameters, "iterationCount"); | |||
| globalThis.testWorstCaseCount = getIntParam(urlParameters, "worstCaseCount"); | |||
| globalThis.prefetchResources = getBoolParam(urlParameters, "prefetchResources", true); | |||
There was a problem hiding this comment.
I would pass globalThis.prefetchResources as the default value rather than true. Seems less likely to cause unexpected behavior if someone manually edits a different part of the script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #58 and is useful for local profiling.
If the prefetchResources is disabled, we now no longer preload them eagerly, but rather use the live URL and either script-inject it or use it directly with workers.
This means we can easily get the original source positions for profiling.
--no-prefetchcommand ilne support&prefetchResources=0URLParam supportDrive-by-fix: