Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event delegation will be much better option instead of forEach() on numberButtons and operationButtons. With forEach() you are creating events for all buttons. That is a bad practice.
With event delegation you don't create click event for each button, just for buttons that are clicked.
This is my solution:
And in HTML file for each number button and operation button data-set value of number for number buttons and operation sign for operation. data-number="1" & data-operation="" For example:
1
2
÷
Select common parent element for all buttons:
const parentElement = document.querySelector('.calculator-grid');
Replace forEach on numberButtons and operationButtons with this code:
parentElement.addEventListener('click', function (e) {
if (e.target.closest('[data-number]')) {
}
if (e.target.closest('[data-operation]')) {
const btnOperation = e.target.closest('[data-operation]');
console.log(btnOperation);
const selectedOperation = btnOperation.getAttribute('data-operation');
console.log(selectedOperation);
calculator.chooseOperation(selectedOperation);
calculator.updateDisplay();
}
});