Add crt2-command.o to provide __main_void#528
Open
yamt wants to merge 3 commits intoWebAssembly:mainfrom
Open
Conversation
Member
|
Could you describe somewhere how this change fixes the bug? |
Contributor
Author
i added some explanation to the PR description. |
Contributor
Author
please let me know if the description was not enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a part of fixes for a regression caused by the shared library support. (#485)
it consists of two changes:
the orignal __main_void in libc is kept for now because we want to support old llvm for the time being.
background:
the shared library support (#429) made the __main_argc_argv reference weak for the benefit of shared library.
unfortunately, it caused a regression in some cases. (#485)
in the PR, it was considered to move __main_void into crt1.o. but the approach had its own subtleties, like breaking --no-gc-sections. (description: #429 (comment))