This repository was archived by the owner on Nov 25, 2025. It is now read-only.
All use flags instead fdflags, and not quote it #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The fdflags->flags change looks good, though the quotes are needed because |
sunfishcode
added a commit
to sunfishcode/wasi-filesystem
that referenced
this pull request
Jul 1, 2022
This matches how the `fd-flags` type was renamed to `flags`. This effectively incorporates the main change from WebAssembly#40. Co-authored-by: Yonggang Luo <luoyonggang@gmail.com>
Member
|
I've now incorporated the fd-flags rename in #52. Thanks for noticing this! |
sunfishcode
added a commit
to sunfishcode/wasi-filesystem
that referenced
this pull request
Jul 5, 2022
This matches how the `fd-flags` type was renamed to `flags`. This effectively incorporates the main change from WebAssembly#40. Co-authored-by: Yonggang Luo <luoyonggang@gmail.com>
sunfishcode
added a commit
that referenced
this pull request
Jul 5, 2022
This matches how the `fd-flags` type was renamed to `flags`. This effectively incorporates the main change from #40. Co-authored-by: Yonggang Luo <luoyonggang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.