Skip to content

Commit 0b32b33

Browse files
Add warning as error to EMCC build
1 parent 0c3b5ac commit 0b32b33

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

.github/workflows/build.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,9 @@ jobs:
7878
run: |
7979
docker run -di --name emscripten -v $(pwd):/src emscripten/emsdk:latest bash
8080
docker exec emscripten emcc -v
81-
docker exec emscripten emcmake cmake .
82-
docker exec emscripten make -j 2 VERBOSE=1
81+
docker exec emscripten emcmake cmake -B emscripten -DWERROR=ON -DBUILD_TESTS=OFF
82+
docker exec emscripten bash -c "cd /src/emscripten && make -j $(nproc)"
83+
8384
wasi:
8485
name: wasi
8586
runs-on: ubuntu-latest

src/c-writer.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1633,7 +1633,7 @@ void CWriter::SerializeFuncType(const FuncType& func_type,
16331633
*next_byte++ = MangleType(func_type.GetResultType(i));
16341634
}
16351635

1636-
assert(next_byte - mangled_signature == len);
1636+
assert(next_byte - mangled_signature == static_cast<ptrdiff_t>(len));
16371637

16381638
// step 4: SHA-256 the whole string
16391639
sha256({mangled_signature, len}, serialized_type);

wasm2c/wasm-rt-impl.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,7 @@ static void os_cleanup_signal_handler(void) {
148148
#endif
149149

150150
#else
151+
#if WASM_RT_USE_MMAP
151152
static void* os_mmap(size_t size) {
152153
int map_prot = PROT_NONE;
153154
int map_flags = MAP_ANONYMOUS | MAP_PRIVATE;
@@ -168,6 +169,7 @@ static int os_mprotect(void* addr, size_t size) {
168169
static void os_print_last_error(const char* msg) {
169170
perror(msg);
170171
}
172+
#endif
171173

172174
#if WASM_RT_INSTALL_SIGNAL_HANDLER
173175
static void os_signal_handler(int sig, siginfo_t* si, void* unused) {

0 commit comments

Comments
 (0)