Rename it for consistence as new and decode is not paired, the real meaning is encode_from, decode_to
#68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to `string.encode_to_*` After doing this, the encode/decode is paired and the direction is clear.
lygstate
commented
Dec 30, 2025
| * `string.decode_from_wtf8` decodes using a strict WTF-8 decoder, which is like | ||
| UTF-8 but also allows isolated surrogates. If the bytes are not | ||
| valid WTF-8, trap. | ||
|
|
Author
There was a problem hiding this comment.
If the bytes are not valid WTF-8, trap
If this is a case. so we may want
string.decode_from_lossy_wtf8, and for invalid characters, replace it with 0xEF 0xBF 0xBD, that's the UTF-8 encoding of U+FFFD (the replacement character)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.