Batch of additional tests #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
|
|
||
| (func $effects (result i32) | ||
| (func "effects" $fx (result i32) |
There was a problem hiding this comment.
why should this be valid? i don't understand what two names for a function means
There was a problem hiding this comment.
This is syntactic sugar for:
(export "effects" $fx)
(func $fx ...)
There was a problem hiding this comment.
Oh, thanks! I missed this part of the issue text...
|
lgtm |
ngzhian
added a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
The error messages don't match the tests yet (simd_lane.wast), that still needs to be worked out in WebAssembly#287.
ngzhian
added a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
- lane indices are u8 (nats), negative values are now parse errors ("unexpected token"), as are values with a positive sign +0x1
- changed a bunch of "expected i8 literal" to "unexpected token", in order to differentiate these syntax errors we probably need to change the parser to match on a bunch of EXTRACT_LANE <token we don't care about>
- some "type mismatch" are now unexpected token
Fixed WebAssembly#287
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Oct 3, 2023
Fix a few typos in the MVP explainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For starters, more tests for:
Also introduced a bit of sugar for exports. You can now write an export name as part of the function def itself:
or, if the symbolic name isn't needed, just
avoiding the tedious triple repetition of the name like before.