This repository was archived by the owner on Apr 25, 2025. It is now read-only.
Merge upstream #26
Merged
Merge upstream #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The links were accidentally changed to point to the reference-types fork when it was merged in 7fa2f20.
Names and affiliations are separated by a comma: https://tabatkins.github.io/bikeshed/#metadata-editor
Same as #1325
Although it was un-exported from HTML recently, this is one of the very few specs which has legitimate reason to link to it.
This addresses issue #1342 for spec publishing. The added workflow will run on commit and PRs and will run CI for both reference interpreter build/test and for building the spec documents. It will also publish them to the gh-pages branch.
Also avoids uploading unnecessary files during publish.
Default branch is now main, so all the PRs are based on main, which means the actions aren't currently triggered, since they only run on push to master. Update it to main. Since we have the main->master mirror, we should still be testing, but it is a bit delayed (only after the mirror I think, and not on the PR).
…ain". Several WebAssembly organization repositories have changed their default branch from "master" to "main": see WebAssembly/design#1417 for details. This PR updates URLs in the spec repository to point to "main" instead of "master", for repositories which have done so.
Similar to 5893af5 but for integers, this is also a type mismatch, but should first be caught at parse time.
Our current version of sphinx doesn't limit the supported docutils versions, and 0.18.0 breaks something (https://docutils.sourceforge.io/RELEASE-NOTES.html#release-0-18-2021-10-26 likely the new meta node) 3.5.4 restricts the docutils versions: https://www.sphinx-doc.org/en/master/changes.html#release-3-5-4-released-apr-11-2021
This syncs the changes made in conf.py to bikeshed/conf.py.
For #1250. More tests for different data types in a follow-up.
v0.11.0 added trust setting that indicates if input text is trusted, this breaks \href. Update to v0.13.19 which accepts a command line flag --trust to trust all inputs. I diffed the singlehtml output, it looks like the only changes are in certain text that were: <span class="mord mathsf">i</span><span class="mord mathsf">3</span><span class="mord mathsf">2</span> became <span class="mord mathsf">i32</span> which is a nice simplification.
Follow-up to #1384 to add checks for all numeric type. Fixes #1250.
Changes: https://www.sphinx-doc.org/en/master/changes.html#release-4-0-0-released-may-09-2021 Things to note: - docutils updated to 0.17 https://docutils.sourceforge.io/RELEASE-NOTES.html#release-0-17-2021-04-03 the big change here is to use semantic elements, <div class="section"> is now <section>, I see this a whole bunch when I diff the output HTML. - supposedly some html themes break due to the docutils change, probably due to divs not matching, I don't see any visible breakage, so it should be fine - mathjax 3 https://docs.mathjax.org/en/latest/upgrading/whats-new-3.0.html it's faster to render, we need to tweak our configuration a bit, to camelCase, so updated it in conf.py I diffed the output html, some differences I noted: - div -> section as noted above - a new meta tag for Docutils - link tag for css, the type and href attributs swapped places - script tag for documetation_options, id and data-url_root swapped places - some css changes in sphinx css files Co-authored-by: Ms2ger <Ms2ger@gmail.com>
This allows us to drop some manual links removal in mathjax2katex.py.
'%F' is not a supported format, see https://github.com/sphinx-doc/sphinx/blob/4.x/sphinx/util/i18n.py#L133, it is also not supported in Python's strftime/strptime https://docs.python.org/3/library/datetime.html#strftime-strptime-behavior. It is however supported in strftime (https://man7.org/linux/man-pages/man3/strftime.3.html) and defined to be "%Y-%m-%d", which is supported by sphinx.
SIMD is [phase 5](WebAssembly/simd#507), merge all the changes back into main spec.
ngzhian
approved these changes
Nov 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge main spec now that SIMD has landed. Required extending SIMD load/store instructions with optional memory index in both spec and interpreter.
Also fixes #16.
Edit: It's annoying that GitHub provides no way to view the merge changes alone. You'll have to check all places in spec and interpreter that deal with SIMD load/store instructions.