Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shuffle operations #62

Open
akirilov-arm opened this issue Oct 25, 2023 · 0 comments
Open

Shuffle operations #62

akirilov-arm opened this issue Oct 25, 2023 · 0 comments

Comments

@akirilov-arm
Copy link

Recently I have reviewed the latest revision of the proposal, and I have several remarks:

  • Concerning the vector combine instructions that operate on vector halves (e.g. vec.f32.concat_lower_lower) - are variants for each element type really necessary? After all, the size of half a vector is independent of the element type, unless the idea is to accommodate the option to set the vector length dynamically, which the current specification allows to do for each element type independently.
  • Is it intentional that there is no vector reverse operation for 8-bit elements?
  • Similarly for duplicate even lanes?
  • As for both left and right shifts by scalar - is the shift amount meant to be unsigned? Otherwise the pseudocode doesn't make sense for negative shift values - it would access the input vector out-of-bounds.
  • The concat_upper_lower operation description (but not the pseudocode) is wrong, i.e. it corresponds to concat_lower_upper.
  • Not a shuffle operation, but I don't want to open a separate issue just for it - the prototypes of the square root operation are binary functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant