Merge binary_0xd #836
Merged
Merge binary_0xd #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titzer
reviewed
Oct 26, 2016
| @@ -104,7 +167,7 @@ The module starts with a preamble of two fields: | |||
| | Field | Type | Description | | |||
| | ----- | ----- | ----- | | |||
| | magic number | `uint32` | Magic number `0x6d736100` (i.e., '\0asm') | | |||
| | version | `uint32` | Version number, currently 12. The version for MVP will be reset to 1. | | |||
| | version | `uint32` | Version number, currently 13. The version for MVP will be reset to 1. | | |||
|
lgtm with nit |
hubot
pushed a commit
to WebKit/WebKit-http
that referenced
this pull request
Dec 1, 2016
https://bugs.webkit.org/show_bug.cgi?id=164724 Reviewed by Saam Barati. As described in the following PR: WebAssembly/design#836 JSTests: * wasm/Builder.js: (const._normalizeFunctionSignature): * wasm/Builder_WebAssemblyBinary.js: (const.emitters.Type): (const.emitters.Code): * wasm/LowLevelBinary.js: (export.default.LowLevelBinary.prototype.block_type): (export.default.LowLevelBinary.prototype.inline_signature_type): Deleted. * wasm/WASM.js: * wasm/js-api/test_basic_api.js: * wasm/self-test/test_BuilderWebAssembly.js: (EmptyModule): (CustomSection): * wasm/self-test/test_WASM.js: * wasm/wasm.json: Source/JavaScriptCore: * wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::B3IRGenerator::B3IRGenerator): (JSC::Wasm::B3IRGenerator::zeroForType): (JSC::Wasm::B3IRGenerator::addConstant): (JSC::Wasm::createJSWrapper): * wasm/WasmCallingConvention.h: (JSC::Wasm::CallingConvention::marshallArgument): * wasm/WasmFormat.cpp: (JSC::Wasm::toString): Deleted. * wasm/WasmFormat.h: (JSC::Wasm::isValueType): (JSC::Wasm::toB3Type): Deleted. * wasm/WasmFunctionParser.h: (JSC::Wasm::FunctionParser<Context>::parseExpression): * wasm/WasmModuleParser.cpp: (JSC::Wasm::ModuleParser::parse): (JSC::Wasm::ModuleParser::parseType): * wasm/WasmModuleParser.h: * wasm/WasmParser.h: (JSC::Wasm::Parser::parseResultType): * wasm/generateWasm.py: (Wasm.__init__): * wasm/generateWasmOpsHeader.py: (cppMacro): (typeMacroizer): (opcodeMacroizer): * wasm/wasm.json: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@209175 268f45cc-cd09-0410-ab3c-d52691b4dbfc
hubot
pushed a commit
to WebKit/WebKit-http
that referenced
this pull request
Dec 3, 2016
https://bugs.webkit.org/show_bug.cgi?id=165345 Reviewed by Keith Miller. As described in the following PR: WebAssembly/design#836 Originally committed in r209175, reverted in r209242, and fixed in r209284. JSTests: * wasm/Builder.js: (const._normalizeFunctionSignature): * wasm/Builder_WebAssemblyBinary.js: (const.emitters.Type): (const.emitters.Code): * wasm/LowLevelBinary.js: (export.default.LowLevelBinary.prototype.block_type): (export.default.LowLevelBinary.prototype.inline_signature_type): Deleted. * wasm/WASM.js: * wasm/js-api/test_basic_api.js: * wasm/self-test/test_BuilderWebAssembly.js: (EmptyModule): (CustomSection): * wasm/self-test/test_WASM.js: * wasm/wasm.json: Source/JavaScriptCore: * wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::B3IRGenerator::B3IRGenerator): (JSC::Wasm::B3IRGenerator::zeroForType): (JSC::Wasm::B3IRGenerator::addConstant): (JSC::Wasm::createJSWrapper): * wasm/WasmCallingConvention.h: (JSC::Wasm::CallingConvention::marshallArgument): * wasm/WasmFormat.cpp: (JSC::Wasm::toString): Deleted. * wasm/WasmFormat.h: (JSC::Wasm::isValueType): (JSC::Wasm::toB3Type): Deleted. * wasm/WasmFunctionParser.h: (JSC::Wasm::FunctionParser<Context>::parseExpression): * wasm/WasmModuleParser.cpp: (JSC::Wasm::ModuleParser::parse): (JSC::Wasm::ModuleParser::parseType): * wasm/WasmModuleParser.h: * wasm/WasmParser.h: (JSC::Wasm::Parser::parseResultType): * wasm/generateWasm.py: (Wasm.__init__): * wasm/generateWasmOpsHeader.py: (cppMacro): (typeMacroizer): (opcodeMacroizer): * wasm/js/WebAssemblyFunction.cpp: (JSC::callWebAssemblyFunction): * wasm/wasm.json: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@209306 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
binary_0xd is now in webassembly.org/demo, spec/interpreter and several engines.
This PR includes one more commit to actually change the version to 0xd.