[emscripten] Don't use -sSINGLE_FILE by default

[sbc100]

Its good to have an option for this by I don't see why it should be the default.

[kripken]

I kind of think it's nice for library providers to give you a single file: just binaryen.js or such. Still, I don't feel strongly, but we should probably check to see how disrupting this change would be for our users.

[sbc100]

Thats why we provide the EMSCRIPTEN_ENABLE_SINGLE_FILE thought right? I'm updated the comment for this option to make to clear what the purpose is and why you might want to enable it.

[kripken]

The flag is good for people building manually, but will this change not affect our own builds? Do we need to flip it in ci to avoid changing what we ship?

[sbc100]

Yes if we are shipping a distribut-able version of binaryen.js then yes, perhaps we want to consider using that flag there. I'll take a look

[sbc100]

It looks like we are shipping binaryen-version_124-node.tar.gz.. for the node case I think having a separate file makes sense since there are not hosting issues to worry about.

I don't see a distributed versions of binaryen.js for the web that we (binaryen) maintains or ship. I think that is all done externally, right?

[sbc100]

It looks like we are shipping binaryen-version_124-node.tar.gz.. for the node case I think having a separate file makes sense since there are not hosting issues to worry about.

I don't see a distributed versions of binaryen.js for the web that we (binaryen) maintains or ship. I think that is all done externally, right?

e.g in https://github.com/AssemblyScript/binaryen.js/? They may choose or use or not use this setting independently of our default.

[kripken]

Yes, I guess that's easily changed there. Worth giving them a heads up I think, but otherwise lgtm

[sbc100]

Head up filed: AssemblyScript/binaryen.js#107