Account for exactness when finding the most refined fallthrough #7544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the automatically generated optimize-instructions-all-casts.wast into two tests: one that tests casts to exact types and another that tests casts to inexact types. For the test file that does not cast to exact types, additionally test with custom descriptors disabled to ensure that the results validate.
Treat exactness as part of the heap type and prefer to refine it over refining nullability. This is a somewhat arbitrary choice, and as shown by the tests, it is possible to construct a situation in which preferring to refine nullability would be preferable.
kripken
approved these changes
Apr 23, 2025
|
|
||
| (module | ||
| ;; CHECK: (type $super (sub (struct))) | ||
| (type $super (sub (struct))) |
Member
There was a problem hiding this comment.
As there is no sub, perhaps this could be called struct?
Member
Author
There was a problem hiding this comment.
I'll use $foo since it doesn't matter that it's a struct in particular, either.
| ;; hoist it to eliminate the cast. | ||
| (ref.cast (ref $super) | ||
| (local.tee 1 | ||
| (local.get 0) |
Member
There was a problem hiding this comment.
Might be clearer to use var names here. And if the param name were $exact (to contrast with the local $inexact or just $struct) then readability would be even better imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat exactness as part of the heap type and prefer to refine it over
refining nullability. This is a somewhat arbitrary choice, and as shown
by the tests, it is possible to construct a situation in which
preferring to refine nullability would be preferable.