Revert "Optimize tuple.extract of gets in BinaryInstWriter" #5945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 56ce1ea.
Codecov Report
@@ Coverage Diff @@
## main #5945 +/- ##
==========================================
- Coverage 42.80% 42.80% -0.01%
==========================================
Files 485 485
Lines 74964 74943 -21
Branches 11966 11958 -8
==========================================
- Hits 32088 32077 -11
+ Misses 39670 39665 -5
+ Partials 3206 3201 -5
|
kripken
approved these changes
Sep 15, 2023
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
…ly#5941)" (WebAssembly#5945) This reverts commit 56ce1ea. The binary writer optimization is not always correct when stack IR optimizations have run. Revert the change until we can fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5941
The binary writer optimization is not always correct when stack IR optimizations have run. Revert the change until we can fix it.