Skip to content

Remove equirecursive typing #5240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Remove equirecursive typing #5240

merged 2 commits into from
Nov 23, 2022

Conversation

tlively
Copy link
Member

@tlively tlively commented Nov 11, 2022

Equirecursive is no longer standards track and its implementation is extremely
complex. Remove it.

@tlively
Copy link
Member Author

tlively commented Nov 11, 2022

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@tlively tlively marked this pull request as draft November 11, 2022 23:01
@tlively
Copy link
Member Author

tlively commented Nov 11, 2022

Converting to draft while I track down why isorecursive canonicalization produces different results on Windows.

@tlively tlively force-pushed the default-isorecursive branch from 5e6eb0e to fb042b2 Compare November 14, 2022 16:34
@tlively tlively force-pushed the remove-equirecursive branch 3 times, most recently from f18bff5 to 8af87c6 Compare November 14, 2022 21:25
@tlively tlively force-pushed the default-isorecursive branch from 5a2f00e to e92ec63 Compare November 15, 2022 02:02
@tlively tlively force-pushed the remove-equirecursive branch from 8af87c6 to 6d8c827 Compare November 15, 2022 02:02
@tlively tlively force-pushed the default-isorecursive branch from e92ec63 to 7a446d2 Compare November 15, 2022 21:11
@tlively tlively force-pushed the remove-equirecursive branch from 6d8c827 to 6cef413 Compare November 15, 2022 21:11
@tlively tlively force-pushed the default-isorecursive branch from 7a446d2 to 11f9981 Compare November 15, 2022 21:39
@tlively tlively force-pushed the remove-equirecursive branch 2 times, most recently from be5e4b0 to 11d7b20 Compare November 15, 2022 22:19
@tlively tlively force-pushed the default-isorecursive branch from 4e7579e to 7331510 Compare November 17, 2022 01:03
@tlively tlively force-pushed the remove-equirecursive branch from 11d7b20 to b07eea9 Compare November 17, 2022 01:03
@tlively tlively force-pushed the default-isorecursive branch from 7331510 to ab33f74 Compare November 18, 2022 15:34
@tlively tlively force-pushed the remove-equirecursive branch from b07eea9 to 5ab9869 Compare November 18, 2022 15:34
@tlively tlively marked this pull request as ready for review November 18, 2022 15:34
@tlively tlively force-pushed the default-isorecursive branch from ab33f74 to 4acf48d Compare November 18, 2022 18:05
@tlively tlively force-pushed the remove-equirecursive branch from 5ab9869 to 3ff156d Compare November 18, 2022 18:05
@tlively tlively mentioned this pull request Nov 18, 2022
@tlively tlively force-pushed the default-isorecursive branch from 4acf48d to 6767c08 Compare November 21, 2022 23:47
@tlively tlively force-pushed the remove-equirecursive branch from 3ff156d to eade7d7 Compare November 21, 2022 23:47
@tlively tlively force-pushed the default-isorecursive branch from 6767c08 to 500e591 Compare November 22, 2022 15:41
@tlively tlively force-pushed the remove-equirecursive branch from eade7d7 to cd961a1 Compare November 22, 2022 15:41
@tlively tlively force-pushed the default-isorecursive branch from 500e591 to b6159e1 Compare November 23, 2022 02:26
@tlively tlively force-pushed the remove-equirecursive branch from cd961a1 to be29b37 Compare November 23, 2022 02:26
Base automatically changed from default-isorecursive to main November 23, 2022 02:49
Equirecursive is no longer standards track and its implementation is extremely
complex. Remove it.
@tlively tlively force-pushed the remove-equirecursive branch from be29b37 to 320446e Compare November 23, 2022 05:17
@tlively tlively enabled auto-merge (squash) November 23, 2022 05:17
@tlively tlively merged commit 2c0fb8c into main Nov 23, 2022
@tlively tlively deleted the remove-equirecursive branch November 23, 2022 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants