When renaming functions ensure the corresponding GOT.func entry is also renamed #2382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Oct 12, 2019
sbc100
force-pushed
the
fix_function_renames
branch
from
6f1d34f to
c8ecfb3
Compare
|
PTAL |
kripken
approved these changes
Oct 22, 2019
|
Please add a test if that is feasible. |
sbc100
force-pushed
the
fix_function_renames
branch
from
c8ecfb3 to
72c4841
Compare
|
From the linked references it sounds like people are hitting this bug, is there a reason not to land this? |
|
Yes, I just added a test too. PTAL. |
kripken
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2180