Validate features for types used in element segments

Author: tlively

scripts/fuzz_opt.py

@@ -364,6 +364,7 @@ def is_git_repo():
     'shared-types-no-gc.wast',
     'shared-ref-i31.wast',
     'table-type.wast',
+    'elem-type.wast',
 ]
 
 

src/wasm/wasm-validator.cpp

@@ -3877,6 +3877,14 @@ static void validateTables(Module& module, ValidationInfo& info) {
       segment->type.isNullable(),
       "elem",
       "Non-nullable reference types are not yet supported for tables");
+    auto typeFeats = segment->type.getFeatures();
+    if (!info.shouldBeTrue(
+          segment->type == funcref || typeFeats <= module.features,
+          "elem",
+          "element segment type requires additional features")) {
+      info.getStream(nullptr)
+        << getMissingFeaturesList(module, typeFeats) << '\n';
+    }
 
     bool isPassive = !segment->table.is();
     if (isPassive) {

test/lit/validation/elem-type.wast

@@ -0,0 +1,12 @@
+;; Test that the features required by element segment types are checked
+
+;; RUN: not wasm-opt %s -all --disable-shared-everything 2>&1 | filecheck %s --check-prefix NO-SHARED
+;; RUN: wasm-opt %s -all -S -o - | filecheck %s --check-prefix SHARED
+
+;; NO-SHARED: element segment type requires additional features
+;; NO-SHARED: [--enable-shared-everything]
+;; SHARED: (elem $e (ref null (shared func)))
+
+(module
+  (elem $e (ref null (shared func)))
+)