[threads] ref.i31_shared requires shared-everything in validation

Author: tlively

scripts/fuzz_opt.py

@@ -362,6 +362,7 @@ def is_git_repo():
     'type-ssa-shared.wast',
     'shared-ref_eq.wast',
     'shared-types-no-gc.wast',
+    'shared-ref-i31.wast',
 ]
 
 

src/wasm/wasm-validator.cpp

@@ -2727,6 +2727,12 @@ void FunctionValidator::visitCallRef(CallRef* curr) {
 void FunctionValidator::visitRefI31(RefI31* curr) {
   shouldBeTrue(
     getModule()->features.hasGC(), curr, "ref.i31 requires gc [--enable-gc]");
+  if (curr->type.isRef() && curr->type.getHeapType().isShared()) {
+    shouldBeTrue(
+      getModule()->features.hasGC(),
+      curr,
+      "ref.i31_shared requires shared-everything [--enable-shared-everything]");
+  }
   shouldBeSubType(curr->value->type,
                   Type::i32,
                   curr->value,

test/lit/validation/shared-ref-i31.wast

@@ -0,0 +1,12 @@
+;; Test that ref.i31_shared requires shared-everything threads
+
+;; RUN: not wasm-opt %s 2>&1 | filecheck %s --check-prefix NO-SHARED
+;; RUN: wasm-opt %s --enable-reference-types --enable-gc --enable-shared-everything -o - -S | filecheck %s --check-prefix SHARED
+
+;; NO-SHARED: ref.i31_shared requires shared-everything [--enable-shared-everything]
+;; SHARED: (ref.i31_shared
+;; SHARED-NEXT: (i32.const 0)
+
+(module
+  (func (drop (ref.i31_shared (i32.const 0))))
+)