Skip to content

Commit 48c96e4

Browse files
committed
[NFC] Expand comment about validating function type features
This addresses feedback missed in #5279.
1 parent 310a4e9 commit 48c96e4

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/wasm/wasm-validator.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2903,7 +2903,9 @@ void FunctionValidator::visitFunction(Function* curr) {
29032903
"Multivalue function results (multivalue is not enabled)");
29042904
}
29052905
FeatureSet features;
2906-
// Check for things like having a rec group with GC enabled.
2906+
// Check for things like having a rec group with GC enabled. The type we're
2907+
// checking is a reference type even if this an MVP function type, so ignore
2908+
// the reference types feature here.
29072909
features |=
29082910
(Type(curr->type, Nullable).getFeatures() & ~FeatureSet::ReferenceTypes);
29092911
for (const auto& param : curr->getParams()) {

0 commit comments

Comments
 (0)