[emscripten] Remove -sWASM_BIGINT flag

This flag has been enabled by default in emscripten for a while now
so I don't think we need this here anymore.

The main user-visible effect of this change is that it makes the
`module.i64.const` JS method now simply take a single bigint rather than
a pair numbers.

Author: sbc100

CMakeLists.txt

@@ -297,21 +297,6 @@ else() # MSVC
 endif()
 
 if(EMSCRIPTEN)
-  # Note: to debug with DWARF you will usually want to enable BIGINT support, as
-  # that helps avoid running Binaryen on the wasm after link. Binaryen's DWARF
-  # rewriting has known limitations, so avoiding it during link is recommended
-  # where possible (like local debugging).
-  #
-  # Note that this is debug info for Binaryen itself, that is, when you are
-  # debugging Binaryen source code. This flag has no impact on what Binaryen
-  # does when run on wasm files.
-  option(ENABLE_BIGINT "Enable wasm BigInt support" OFF)
-  if(ENABLE_BIGINT)
-    add_link_flag("-sWASM_BIGINT")
-   else()
-    add_link_flag("-sWASM_BIGINT=0")
-  endif()
-
   if("${CMAKE_BUILD_TYPE}" MATCHES "Release")
     # Extra check that cmake has set -O3 in its release flags.
     # This is really as an assertion that cmake is behaving as we expect.

scripts/test/shared.py

@@ -195,7 +195,7 @@ def is_exe(fpath):
             which('gcc') or which('clang'))
 NATIVEXX = (os.environ.get('CXX') or which('mingw32-g++') or
             which('g++') or which('clang++'))
-NODEJS = os.environ.get('NODE') or which('node') or which('nodejs')
+NODEJS = os.environ.get('NODE') or os.environ.get('EMSDK_NODE') or which('node') or which('nodejs')
 MOZJS = which('mozjs') or which('spidermonkey')
 
 V8 = os.environ.get('V8') or which('v8') or which('d8')
@@ -264,9 +264,8 @@ def has_shell_timeout():
 
 try:
     if NODEJS is not None:
-        subprocess.check_call([NODEJS, '--version'],
-                              stdout=subprocess.PIPE,
-                              stderr=subprocess.PIPE)
+        version = subprocess.check_output([NODEJS, '--version'])
+        print(f'Using node ({NODEJS}) version: {version.strip()}')
 except (OSError, subprocess.CalledProcessError):
     NODEJS = None
 if NODEJS is None:

src/js/binaryen.js-post.js

@@ -1,3 +1,5 @@
+#preprocess
+
 // export friendly API methods
 function preserveStack(func) {
   try {
@@ -1090,12 +1092,22 @@ function wrapModule(module, self = {}) {
     'store32'(offset, align, ptr, value, name) {
       return preserveStack(() => Module['_BinaryenStore'](module, 4, offset, align, ptr, value, Module['i64'], strToStack(name)));
     },
+#if WASM_BIGINT
     'const'(x, y) {
       return preserveStack(() => {
         const tempLiteral = stackAlloc(sizeOfLiteral);
         Module['_BinaryenLiteralInt64'](tempLiteral, x, y);
         return Module['_BinaryenConst'](module, tempLiteral);
       });
+#else
+    'const'(x) {
+      return preserveStack(() => {
+        assert(typeof x == 'bigint', 'i64.const requires a bigint');
+        const tempLiteral = stackAlloc(sizeOfLiteral);
+        Module['_BinaryenLiteralInt64'](tempLiteral, x);
+        return Module['_BinaryenConst'](module, tempLiteral);
+      });
+#endif
     },
     'clz'(value) {
       return Module['_BinaryenUnary'](module, Module['ClzInt64'], value);