Skip to content

Commit 1079a9e

Browse files
authored
Re-enable spec tests requiring multivalue (#6684)
And delete tests that no longer pass now that multivalue is standard.
1 parent 45f6bdd commit 1079a9e

File tree

3 files changed

+18
-42
lines changed

3 files changed

+18
-42
lines changed

scripts/test/shared.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -406,8 +406,6 @@ def get_tests(test_dir, extensions=[], recursive=False):
406406
'linking.wast',
407407

408408
# Invalid module accepted
409-
'func.wast',
410-
'type.wast',
411409
'unreached-invalid.wast',
412410

413411
# Test invalid

test/spec/func.wast

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -489,19 +489,6 @@
489489

490490
;; Invalid typing of result
491491

492-
(assert_invalid
493-
(module (func $type-multiple-result (result i32 i32) (unreachable)))
494-
"invalid result arity"
495-
)
496-
(assert_invalid
497-
(module
498-
(type (func (result i32 i32)))
499-
(func $type-multiple-result (type 0) (unreachable))
500-
)
501-
"invalid result arity"
502-
)
503-
504-
505492
(assert_invalid
506493
(module (func $type-empty-i32 (result i32)))
507494
"type mismatch"

test/spec/type.wast

Lines changed: 18 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -11,33 +11,33 @@
1111
(type (func (param $x i32) (result i32)))
1212

1313
(type (func (param f32 f64)))
14-
;; (type (func (result i64 f32)))
15-
;; (type (func (param i32 i64) (result f32 f64)))
14+
(type (func (result i64 f32)))
15+
(type (func (param i32 i64) (result f32 f64)))
1616

1717
(type (func (param f32) (param f64)))
1818
(type (func (param $x f32) (param f64)))
1919
(type (func (param f32) (param $y f64)))
2020
(type (func (param $x f32) (param $y f64)))
21-
;; (type (func (result i64) (result f32)))
22-
;; (type (func (param i32) (param i64) (result f32) (result f64)))
23-
;; (type (func (param $x i32) (param $y i64) (result f32) (result f64)))
21+
(type (func (result i64) (result f32)))
22+
(type (func (param i32) (param i64) (result f32) (result f64)))
23+
(type (func (param $x i32) (param $y i64) (result f32) (result f64)))
2424

2525
(type (func (param f32 f64) (param $x i32) (param f64 i32 i32)))
26-
;; (type (func (result i64 i64 f32) (result f32 i32)))
27-
;; (type
28-
;; (func (param i32 i32) (param i64 i32) (result f32 f64) (result f64 i32))
29-
;; )
26+
(type (func (result i64 i64 f32) (result f32 i32)))
27+
(type
28+
(func (param i32 i32) (param i64 i32) (result f32 f64) (result f64 i32))
29+
)
3030

3131
(type (func (param) (param $x f32) (param) (param) (param f64 i32) (param)))
32-
;; (type
33-
;; (func (result) (result) (result i64 i64) (result) (result f32) (result))
34-
;; )
35-
;; (type
36-
;; (func
37-
;; (param i32 i32) (param i64 i32) (param) (param $x i32) (param)
38-
;; (result) (result f32 f64) (result f64 i32) (result)
39-
;; )
40-
;; )
32+
(type
33+
(func (result) (result) (result i64 i64) (result) (result f32) (result))
34+
)
35+
(type
36+
(func
37+
(param i32 i32) (param i64 i32) (param) (param $x i32) (param)
38+
(result) (result f32 f64) (result f64 i32) (result)
39+
)
40+
)
4141
)
4242

4343
(assert_malformed
@@ -48,12 +48,3 @@
4848
(module quote "(type (func (result $x i32)))")
4949
"unexpected token"
5050
)
51-
52-
(assert_invalid
53-
(module (type (func (result i32 i32))))
54-
"invalid result arity"
55-
)
56-
(assert_invalid
57-
(module (type (func (result i32) (result i32))))
58-
"invalid result arity"
59-
)

0 commit comments

Comments
 (0)