Skip to content

Commit 091a50c

Browse files
authored
Remove unused Pass::prepareToRun (#3386)
1 parent e2e2a7d commit 091a50c

File tree

3 files changed

+0
-14
lines changed

3 files changed

+0
-14
lines changed

src/pass.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -268,10 +268,6 @@ class Pass {
268268
public:
269269
virtual ~Pass() = default;
270270

271-
// Override this to perform preparation work before the pass runs.
272-
// This will be called before the pass is run on a module.
273-
virtual void prepareToRun(PassRunner* runner, Module* module) {}
274-
275271
// Implement this with code to run the pass on the whole module
276272
virtual void run(PassRunner* runner, Module* module) {
277273
WASM_UNREACHABLE("unimplemented");

src/passes/pass.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -670,7 +670,6 @@ void PassRunner::runOnFunction(Function* func) {
670670
}
671671

672672
void PassRunner::doAdd(std::unique_ptr<Pass> pass) {
673-
pass->prepareToRun(this, wasm);
674673
passes.emplace_back(std::move(pass));
675674
}
676675

src/wasm-module-building.h

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -122,15 +122,6 @@ class OptimizingIncrementalModuleBuilder {
122122
return;
123123
}
124124

125-
// Before parallelism, create all passes on the main thread here, to ensure
126-
// prepareToRun() is called for each pass before we start to optimize
127-
// functions.
128-
{
129-
PassRunner passRunner(wasm, passOptions);
130-
addPrePasses(passRunner);
131-
passRunner.addDefaultFunctionOptimizationPasses();
132-
}
133-
134125
// prepare work list
135126
endMarker = new Function();
136127
list = new std::atomic<Function*>[numFunctions];

0 commit comments

Comments
 (0)