Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Session manager constructor Updates #14

Merged
merged 2 commits into from
Sep 17, 2024
Merged

feat: Session manager constructor Updates #14

merged 2 commits into from
Sep 17, 2024

Conversation

grvgoel81
Copy link
Collaborator

Motivation and Context

  • Session manager constructor Updates

Jira Link:

Description

  • Session manager constructor Updates

How has this been tested?

  • By running test cases.

Screenshots (if appropriate):

Screenshot 2024-09-16 at 4 13 47 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@grvgoel81
feat: added origin header in authorize session API.
c52ec3d 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
@grvgoel81
feat: change sessionTime variable type to Int.
1480c9c 
Signed-off-by: Gaurav Goel <gaurav@tor.us>
chaitanyapotti
chaitanyapotti approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit c77fde3 into master Sep 17, 2024
2 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/constructor-updates branch September 17, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grvgoel81 @chaitanyapotti