Skip to content

Commit 2188dfd

Browse files
committed
GET-1949 | feat(new-loan): fixing code quality tests
1 parent 7062c9d commit 2188dfd

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/Client.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ public static function make(AuthEntity $authEntity): Client
3636
* @SuppressWarnings(PHPMD.StaticAccess)
3737
*
3838
* @param LoanRequestEntity $requestEntity
39-
* @return ResponseEntity
4039
* @throws EntityValidationException
40+
* @return ResponseEntity
4141
*/
4242
public function requestNewLoan(LoanRequestEntity $requestEntity): ResponseEntity
4343
{

src/Entity/Request/UpdateShippingStatusRequestEntity.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,28 +28,28 @@ class UpdateShippingStatusRequestEntity extends AbstractRequestEntity
2828
* message = "Choose a valid shipment status."
2929
* )
3030
*/
31-
public null|string $shippingStatus;
31+
public ?string $shippingStatus;
3232

3333
/**
3434
* @Assert\NotNull(message = "The value of tracking id status should not be null.")
3535
*/
36-
public null|string $trackingId;
36+
public ?string $trackingId;
3737

3838
/**
3939
* @Assert\NotNull(message = "The value of tracking company should not be null.")
4040
*/
41-
public null|string $trackingCompany;
41+
public ?string $trackingCompany;
4242

4343
/**
4444
* @Assert\NotNull(message = "The value of delivery date should not be null.")
4545
* @Assert\Date(message = "The value of delivery date is not a valid Date with format YYYY-MM-DD.")
4646
*/
47-
public null|string $deliveryDate;
47+
public ?string $deliveryDate;
4848

4949
/**
5050
* @Assert\NotNull(message = "The value of invId should not be null.")
5151
*/
52-
protected null|string $invId;
52+
protected ?string $invId;
5353

5454
/**
5555
* @SuppressWarnings(PHPMD.StaticAccess)

0 commit comments

Comments
 (0)