Skip to content

Commit 99b8b32

Browse files
author
Charlotte Spencer
authored
fix: suggested changes to the rfc-pairing doc
Thanks @adamipc
1 parent e0f747b commit 99b8b32

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

_pages/rfc-pairing.md

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,19 @@ permalink: /rfc-pairing
1010
{: text-italic}
1111

1212
Learning is cool! Programming is hard! Learning with someone else is often way more productive than trying to learn alone.
13-
We All JS strives to be a community where people learning something new, no matter their level of skill can find support.
13+
We All JS strives to be a community where people learning something new, no matter their level of skill, can find support.
1414
Here at We All JS, we recommend two different forms of cooperative programming.
1515

1616
## Code Review
17-
Code review is an extremely useful medium for cooperative learning. A more experienced person code reviewing code from a
18-
newcomer might find that new techniques and technologies have emerged that are out of their expertise. Newcomers can benefit
17+
18+
Code review is an extremely useful medium for cooperative learning. A more experienced person reviewing code from a newcomer
19+
might find that new techniques and technologies have emerged that are out of their expertise. Newcomers can benefit
1920
from the knowledge of individuals who have put their experience to the test.
2021

21-
You are free to ask for code review in anyway you like, but here is our suggestion
22+
You are free to ask for code review in any way you like, but here is our suggestion
2223
* Push your code to a Github repository.
2324
* Open a feature branch, and start coding away.
24-
* Push the feature branch upstream, and open a pull request from that feature branch into master. To do this, go to your
25+
* Push the feature branch upstream, and open a pull request from that feature branch into master. To do this, go to your
2526
project's homepage, and there should be a button that says **New pull request**. Click this button. Select master as your base
2627
branch, and your feature branch as the compare branch. Then, click the **Create pull request** button.
2728
* This should bring you to a page where you can write a description. Describe your problem, and what your pull request is aiming to
@@ -33,7 +34,7 @@ frameworks you are using.
3334
Hovering your mouse over the diff should display a plus sign. Clicking on this plus sign will allow the reviewer to make line notes
3435
* As reviews come in, respond to code review by making appropriate code changes. You are also able to reply to inline comment by
3536
commenting on the same line. Talk it out, and don't be afraid to ask questions either on the pull request page, or on
36-
the pairing page. Push up any commits you make in the process.
37+
the `#pairing` channel. Push up any commits you make in the process.
3738
* Once reviewers feel good about the code, they can send a :+1: or a +1 to indicate the commit looks ready to be merged
3839
into master. They can do this by going to the main pull request page, scrolling to the bottom, entering text into the
3940
comment box, and pressing **Comment**.
@@ -55,7 +56,7 @@ your code. When responding to code review, fear feature creep. Try your very bes
5556
review is complete.
5657

5758
## Live Pairing
58-
Live pairing involves two or more people on a call, looking at the same code. Feel free to put out calls for live pairing
59+
Live pairing involves two or more people on a call, looking at the same code. Feel free to make requests for live pairing
5960
in the channel. You can be someone looking to pair on someone else's work, or someone looking to pair on your own work.
6061
We ask that, when searching for live pairing, that you please be open to working with people of all skill levels.
6162
Additionally, we require that you respect all We All JS rules while pairing with other members of the Slack.

0 commit comments

Comments
 (0)