Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review required features #107

Open
5 tasks
markwhiting opened this issue May 9, 2022 · 0 comments
Open
5 tasks

Review required features #107

markwhiting opened this issue May 9, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@markwhiting
Copy link
Member

Required is quite simple now and has some failure modes as a consequence. For example checkboxes can't have required because they are seen as independent inputs (so all are required) e.g., #106, and we have no way to enter nuanced validations such as a number between 1 and 10.

This requires us to make a plan around how to deal with some popular and edge cases for required, and at least the following:

  • fix required for checkboxes so that it has a default behavior like "at least one checkbox is checked"
  • consider how required might work for each input type and make a plan for possible validation rule schema we could use for each one. Document this ideation in the thread here and get agreement on a strategy with @markwhiting before implementing.
  • once approaches are decided upon, implement them
  • create documentation to describe how each requirement schema works
  • create tests to check that each required mechanism is working and robust (including ones that do not require new validation schema)

This is done when all steps above are complete and all other tests pass.

@markwhiting markwhiting added the enhancement New feature or request label Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant