Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round corners don't nest #59

Open
markwhiting opened this issue Jul 2, 2024 · 2 comments
Open

Round corners don't nest #59

markwhiting opened this issue Jul 2, 2024 · 2 comments
Labels

Comments

@markwhiting
Copy link
Member

Round corners should nest, e.g., bigger round corners should share the center point with smaller ones positioned in them, such as the situation in our scope selector.

It looks like we have a radius of 4 on the inside ones and padding of 8, so the outside ones should be 12, not 16 as they are. I have set the top left in this image to 12 and it looks neater.

Screenshot 2024-07-02 at 09 56 27
@markwhiting
Copy link
Member Author

More generally, we should always do this. Everywhere and forever. haha

@markwhiting markwhiting changed the title Round corners don't next Round corners don't nest Jul 2, 2024
@markwhiting
Copy link
Member Author

I think now outside the area also has R = 4, which is not great either. I'd make it so that R_inside + padding = R_outside, such that the round corners of inside and outside share a center point.

@amirrr amirrr added the frontend label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants