Autonamespace fix #1305
Merged
Autonamespace fix #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quetool
approved these changes
Feb 13, 2024
| @@ -11,8 +11,12 @@ final class SessionProposalInteractor { | |||
|
|
|||
| let supportedRequiredChains = proposal.requiredNamespaces["eip155"]?.chains | |||
| let supportedOptionalChains = proposal.optionalNamespaces?["eip155"]?.chains ?? [] | |||
| let supportedChains = (supportedRequiredChains ?? []).union(supportedOptionalChains) ?? [] | |||
|
|
|||
| var supportedChains = (supportedRequiredChains ?? []).union(supportedOptionalChains) ?? [] | |||
There was a problem hiding this comment.
Prolly a nitpick but, would be useful to make supportedChains a Set in case supportedRequiredChains and supportedOptionalChains have repeated chains? Like [eip155:1, eip155:137, eip155:10] and [eip155:137, eip155:10, eip155:56, .....]
There was a problem hiding this comment.
union is a Set method :D
There was a problem hiding this comment.
Nice! I've told you I'm rusty :D
There was a problem hiding this comment.
I think it applies to every language
There was a problem hiding this comment.
To every language that has it maybe :P
xwal
reviewed
Feb 19, 2024
| case unsupportedChains | ||
| case unsupportedMethods | ||
| case unsupportedAccounts | ||
| case upsupportedEvents |
There was a problem hiding this comment.
upsupportedEvents misspelled word
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes a bug with required chains validation
Resolves # (issue)
How Has This Been Tested?
Due Dilligence