Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make groupIdentifier optional #1335

Open
muratogat opened this issue Mar 28, 2024 · 3 comments
Open

Make groupIdentifier optional #1335

muratogat opened this issue Mar 28, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@muratogat
Copy link

Is your feature request related to a problem? Please describe.
We can't simply update the WalletConnect SDK, since now the groupIdentifier is required. I am required to create an App Group in the Apple Developer Portal.
Context:
Networking.configure(groupIdentifier: , projectId: , socketFactory: SocketFactory())
https://docs.walletconnect.com/api/core/relay#networking-client-configuration
#1264 (comment)

Describe the solution you'd like
Make groupIdentifier optional. Not all apps are interested in your Notify API.

Additional context
I think it is too far reaching that you feel entitled to make app developers mandatory changes that even touch app provisioning and keychain levels, for questionable functionality that an app may not want.
This kind of behavior and engineering choices not only create a lot of work for developers who are trying to stay updated, it also actively discourages people from following your releases, complying with new standards or supporting WalletConnect at all.

@muratogat muratogat added the enhancement New feature or request label Mar 28, 2024
@SunZhiC
Copy link

SunZhiC commented Apr 9, 2024

Exactly, I can't connect without an entitlement file, I don't need group feature.

Auth token creation error: OSStatus: -34018, message: A required entitlement isn't present.

@nirmalpatidar123
Copy link

For iOS new declaration API, I need to update the library but getting above mentioned error.
Auth token creation error: OSStatus: -34018, message: A required entitlement isn't present.

@muratogat
Copy link
Author

It's been 3 weeks since the issue has been opened. Please at least acknowledge and communicate how you will handle this problem.

Together with #1319 , this will make it impossible for apps to submit an update after May 1, if they refuse to add App Groups, or not allowed to do so. So in practice, you are pushing a requirement to wallets, that opens up another attack vector, for some functionality they may not need. Please make this function optional until May 1, so people can actually update your SDK.

From Apple documentation:

An App Group allows multiple apps developed by the same team to access one or more shared containers. It also enables additional inter-process communication between those apps using Mach IPC, POSIX semaphores and shared memory, and UNIX domain sockets, among other IPC mechanisms.

@llbartekll llbartekll self-assigned this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants