Breaking: Coerce total and total pages link header values to integer

While this may not be the cause of #332, coercing the values to numbers
will avoid any issues with leading or trailing spaces/returns, and can
make it easier to utilize the returned values.

Author: kadamwhite

lib/http-transport.js

@@ -125,7 +125,7 @@ function createPaginationObject( result, options, httpTransport ) {
 		return _paging;
 	}
 
-	const totalPages = result.headers[ 'x-wp-totalpages' ];
+	const totalPages = +result.headers[ 'x-wp-totalpages' ];
 
 	if ( ! totalPages || totalPages === '0' ) {
 		// No paging: return as-is
@@ -139,7 +139,7 @@ function createPaginationObject( result, options, httpTransport ) {
 
 	// Store pagination data from response headers on the response collection
 	_paging = {
-		total: result.headers[ 'x-wp-total' ],
+		total: +result.headers[ 'x-wp-total' ],
 		totalPages: totalPages,
 		links: links,
 	};

tests/integration/categories.js

@@ -97,7 +97,7 @@ describe( 'integration: categories()', () => {
 				.get()
 				.then( ( categories ) => {
 					expect( categories._paging ).toHaveProperty( 'total' );
-					expect( categories._paging.total ).toBe( '65' );
+					expect( categories._paging.total ).toBe( 65 );
 					return SUCCESS;
 				} );
 			return expect( prom ).resolves.toBe( SUCCESS );
@@ -108,7 +108,7 @@ describe( 'integration: categories()', () => {
 				.get()
 				.then( ( categories ) => {
 					expect( categories._paging ).toHaveProperty( 'totalPages' );
-					expect( categories._paging.totalPages ).toBe( '7' );
+					expect( categories._paging.totalPages ).toBe( 7 );
 					return SUCCESS;
 				} );
 			return expect( prom ).resolves.toBe( SUCCESS );

tests/integration/comments.js

@@ -121,7 +121,7 @@ describe( 'integration: comments()', () => {
 				.get()
 				.then( ( posts ) => {
 					expect( posts._paging ).toHaveProperty( 'total' );
-					expect( posts._paging.total ).toBe( '25' );
+					expect( posts._paging.total ).toBe( 25 );
 					return SUCCESS;
 				} );
 			return expect( prom ).resolves.toBe( SUCCESS );
@@ -132,7 +132,7 @@ describe( 'integration: comments()', () => {
 				.get()
 				.then( ( posts ) => {
 					expect( posts._paging ).toHaveProperty( 'totalPages' );
-					expect( posts._paging.totalPages ).toBe( '3' );
+					expect( posts._paging.totalPages ).toBe( 3 );
 					return SUCCESS;
 				} );
 			return expect( prom ).resolves.toBe( SUCCESS );

tests/integration/media.js

@@ -120,7 +120,7 @@ describe( 'integration: media()', () => {
 				.get()
 				.then( ( media ) => {
 					expect( media._paging ).toHaveProperty( 'totalPages' );
-					expect( media._paging.totalPages ).toBe( '4' );
+					expect( media._paging.totalPages ).toBe( 4 );
 					return SUCCESS;
 				} );
 			return expect( prom ).resolves.toBe( SUCCESS );

tests/integration/pages.js

@@ -87,7 +87,7 @@ describe( 'integration: pages()', () => {
 				.get()
 				.then( ( pages ) => {
 					expect( pages._paging ).toHaveProperty( 'total' );
-					expect( pages._paging.total ).toBe( '18' );
+					expect( pages._paging.total ).toBe( 18 );
 					return SUCCESS;
 				} );
 			return expect( prom ).resolves.toBe( SUCCESS );
@@ -98,7 +98,7 @@ describe( 'integration: pages()', () => {
 				.get()
 				.then( ( pages ) => {
 					expect( pages._paging ).toHaveProperty( 'totalPages' );
-					expect( pages._paging.totalPages ).toBe( '2' );
+					expect( pages._paging.totalPages ).toBe( 2 );
 					return SUCCESS;
 				} );
 			return expect( prom ).resolves.toBe( SUCCESS );

tests/integration/posts.js

@@ -140,7 +140,7 @@ describe( 'integration: posts()', () => {
 				.get()
 				.then( ( posts ) => {
 					expect( posts._paging ).toHaveProperty( 'totalPages' );
-					expect( posts._paging.totalPages ).toBe( '4' );
+					expect( posts._paging.totalPages ).toBe( 4 );
 					return SUCCESS;
 				} );
 			return expect( prom ).resolves.toBe( SUCCESS );

tests/integration/tags.js

@@ -102,7 +102,7 @@ describe( 'integration: tags()', () => {
 				.get()
 				.then( ( tags ) => {
 					expect( tags._paging ).toHaveProperty( 'total' );
-					expect( tags._paging.total ).toBe( '110' );
+					expect( tags._paging.total ).toBe( 110 );
 					return SUCCESS;
 				} );
 			return expect( prom ).resolves.toBe( SUCCESS );
@@ -113,7 +113,7 @@ describe( 'integration: tags()', () => {
 				.get()
 				.then( ( tags ) => {
 					expect( tags._paging ).toHaveProperty( 'totalPages' );
-					expect( tags._paging.totalPages ).toBe( '11' );
+					expect( tags._paging.totalPages ).toBe( 11 );
 					return SUCCESS;
 				} );
 			return expect( prom ).resolves.toBe( SUCCESS );