Skip to content

Fix falsy args filtering #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix falsy args filtering #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/ast.generator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ function convertArray(arrayArgument, previousInstance = yup) {

// Handle the case when we've got an array of empty elements
if (convertedArguments instanceof Array) {
if (convertedArguments.filter(i => i).length < 1) {
if (convertedArguments.filter(i => i !== undefined).length < 1) {
return gotFunc();
}

Expand Down
9 changes: 9 additions & 0 deletions source/tests/converter.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,15 @@ const numberTests = [
failure: [1, 2, 3, 4, 501, 502, 503],
},
},
{
name: 'Converts simple type with falsy args',
input: [['yup.number'], ['yup.required'], ['yup.min', 0]],
validates: {
// prettier-no-wrap
success: [0, 50],
failure: [-50],
},
},
];

const stringTests = [
Expand Down