Fix falsy args filtering #8
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this expression
yup-ast/source/ast.generator.js
Line 129 in 80f91ca
is filtering out falsy values like
0,'',null,false, etc.This means that:
AR
Will fail with the message
ER
Will succeed, returning the
42value.Thoughts
I assume that it's supposed to skip only
undefinedvalues instead so I created this PR. Please correct me if I'm wrong. Thank you!You can check that the new test with
0fails if you remove the!== undefinedpart.