added conditional check if gotFunc is a function else return

[cdoshi]

Issue is that if we use custom validators, the library throws an error saying it's not a function. Issue is that the custom validator is already a schema based on your documentation hence it just needs to be returned as is

[tavurth]

Perhaps it would be better to check if the gotFunc is instanceof a schema?

[cdoshi]

@tavurth yes, it makes sense to check if its a schema. Take a look at how I have done it. I am not sure if that's the right way to do it

[tavurth]

I see from the Yup documentation, that they have a few different schema types.

Perhaps something like this:

+/**
+ * Returns true if the passed item is a yup.Schema
+ * @param {maybeSchema} item - Item to check
+ */
+function isSchema(item) {
+  return [
+    // All possible yup schema types
+    yup.mixed,
+    yup.date,
+    yup.array,
+    yup.string,
+    yup.number,
+    yup.object,
+    yup.boolean,
+  ].some(schemaType => item instanceof schemaType);
+}
+

@@ -129,7 +146,7 @@ function convertArray(arrayArgument, previousInstance = yup) {
         if (convertedArguments.filter(i => i).length < 1) {
           if (typeof gotFunc === 'function') {
             return gotFunc();
-          } else if (typeof gotFunc === 'object' && gotFunc.constructor.name.toLowerCase().indexOf('schema') > -1) {
+          } else if (isSchema(gotFunc)) {
             return gotFunc;
           }
         }

[tavurth]

I'm unable to test the above but it seems a little more friendly.

Also please be aware that this repository owner does not seem to accept PRs at this time

[cdoshi]

@tavurth What do you recommend? Create another npm module?