Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pasting a webaudio chip with advdupe2 causes a lua error #56

Open
Andrew-Eathan opened this issue Jun 17, 2022 · 1 comment
Open

pasting a webaudio chip with advdupe2 causes a lua error #56

Andrew-Eathan opened this issue Jun 17, 2022 · 1 comment
Labels
bug Something isn't working Complexity: Hard Something that would be very difficult to implement. Requiring a change in the system around it.

Comments

@Andrew-Eathan
Copy link

sv: Expression 2 (dad snoring): lua/entities/gmod_wire_expression2/core/custom/webaudio.lua:837: attempt to call method 'IsValid' (a nil value)

@Andrew-Eathan Andrew-Eathan added the bug Something isn't working label Jun 17, 2022
@Vurv78 Vurv78 added the Complexity: Hard Something that would be very difficult to implement. Requiring a change in the system around it. label Jun 18, 2022
@Vurv78
Copy link
Owner

Vurv78 commented Jun 18, 2022

This is another issue I currently have no idea how to fix as it has to do with the internals of wire/e2, maybe it isn't as bad as #55 but still will take a good while to figure out why this is happening.

Right now the code is being called with A having all of the fields and whatever of a WebAudio object, but is missing the metatable, so the IsValid function doesn't exist. I could replace that method call with just IsValid (and probably will cause I'm lazy) but it'd be good to look into why this is happening at all since maybe this could be linked to #55 as well.

The only way for that to happen though is if it literally serialized the webaudio and stored it for use across the dupe, which is dumb and I don't think E2 should/does do that. I also don't remember if advdupe triggers first() (I swear duped() was only for regular duplicator, but w/e)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Complexity: Hard Something that would be very difficult to implement. Requiring a change in the system around it.
Projects
None yet
Development

No branches or pull requests

2 participants