From ea8027494770b55a1635fdcf534fd69347f36d68 Mon Sep 17 00:00:00 2001 From: Jack Gerrits Date: Fri, 7 Jul 2023 09:11:00 -0400 Subject: [PATCH] fix: coin's learn does not return a prediction, update to reflect The prediction it currently returns essentially represents what the prediction would have been post learn and therefore does not match the contract of learn_returns_prediction, --- vowpalwabbit/core/src/reductions/ftrl.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vowpalwabbit/core/src/reductions/ftrl.cc b/vowpalwabbit/core/src/reductions/ftrl.cc index be1116fac10..129f69012ab 100644 --- a/vowpalwabbit/core/src/reductions/ftrl.cc +++ b/vowpalwabbit/core/src/reductions/ftrl.cc @@ -458,7 +458,7 @@ std::shared_ptr VW::reductions::ftrl_setup(VW::setup_base_ all.output_config.audit || all.output_config.hash_inv ? learn_coin_betting : learn_coin_betting; all.weights.stride_shift(3); // NOTE: for more parameter storage b->ftrl_size = 6; - learn_returns_prediction = true; + learn_returns_prediction = false; } b->data.ftrl_alpha = b->ftrl_alpha; @@ -498,4 +498,4 @@ std::shared_ptr VW::reductions::ftrl_setup(VW::setup_base_ .set_print_update(VW::details::print_update_simple_label) .build(); return l; -} \ No newline at end of file +}