Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Song language is not copied to lyrics language + can be overwritten by lyrics language detection #1715

Open
2 of 7 tasks
szc126 opened this issue Mar 15, 2024 · 0 comments
Open
2 of 7 tasks
Labels
adding/editing entries Adding/Editing entries (artists, songs, albums, tags, song lists, events) bug/error Bugs and errors (timeout) complexity: unknown Unknown days of work content: entry-languages Entry languages data-field content: lyrics Song lyrics content: songs Song entries priority: low Issues/Tasks that are not so important

Comments

@szc126
Copy link
Collaborator

szc126 commented Mar 15, 2024

Website (required)

VocaDB

Describe the bug (required)

  1. Song language is not copied to the lyrics language field.
  2. After adding lyrics, the detected language will overwrite the song language.

To Reproduce (optional)

Steps to reproduce the behavior:

  1. Open a song edit page
  2. Set the song language
  3. Add lyrics of a different language
  4. Wait for lyrics language to be detected (automatically change from "Other/Unknown" (!!))
  5. Save the song entry

Expected behavior (optional)

  1. Lyrics language is autofilled with the song language.
  2. Song language is obeyed and not overwritten

Additional context (optional)

Related to #1695?

Checklist (required)

Fill out the checklist. Use strikethroughs or leave fields empty if you don't know or are unable to check/test.

  • Searched VocaDB/vocadb for duplicate issues.
  • Tested on the beta site.
  • Tested on different browsers (e.g. Firefox, Chrome, Safari, Edge).
  • Checked in private mode.
  • Cleared browser cache and cookies.
  • Checked the DevTools console.
  • Checked the syslog (mods+ only).
@andreoda andreoda added priority: low Issues/Tasks that are not so important complexity: unknown Unknown days of work bug/error Bugs and errors (timeout) content: lyrics Song lyrics content: entry-languages Entry languages data-field content: songs Song entries adding/editing entries Adding/Editing entries (artists, songs, albums, tags, song lists, events) labels Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adding/editing entries Adding/Editing entries (artists, songs, albums, tags, song lists, events) bug/error Bugs and errors (timeout) complexity: unknown Unknown days of work content: entry-languages Entry languages data-field content: lyrics Song lyrics content: songs Song entries priority: low Issues/Tasks that are not so important
Projects
Development

No branches or pull requests

2 participants