Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lyrics not inherited from parent entry after deleting child entry's lyrics #1674

Open
1 of 7 tasks
saturclay opened this issue Feb 5, 2024 · 2 comments
Open
1 of 7 tasks
Labels
adding/editing entries Adding/Editing entries (artists, songs, albums, tags, song lists, events) bug/error Bugs and errors (timeout) complexity: unknown Unknown days of work content: lyrics Song lyrics content: songs Song entries entry-activity Entry activities/changes to entries, Entry reports priority: low Issues/Tasks that are not so important

Comments

@saturclay
Copy link
Contributor

Website (required)

VocaDB / UtaiteDB / [TouhouDB] (presumably true of other DBs as well)

Describe the bug (required)

After adding and deleting the lyrics from a song, it no longer inherits the lyrics of the parent version.
See here for the song in question.

To Reproduce (optional)

Steps to reproduce the behavior:

  1. Add lyrics for a song where the parent version already has lyrics and save the entry.
  2. Edit the entry again and remove the lyrics.
  3. Even if you revert the entry to before lyrics were added, the lyrics still don't inherit from the parent version.

Checklist (required)

Fill out the checklist. Use strikethroughs or leave fields empty if you don't know or are unable to check/test.

  • Searched VocaDB/vocadb for duplicate issues.
  • Tested on the beta site.
  • Tested on different browsers (e.g. Firefox, Chrome, Safari, Edge).
  • Checked in private mode.
  • Cleared browser cache and cookies.
  • Checked the DevTools console.
  • Checked the syslog (mods+ only).
@andreoda
Copy link
Member

andreoda commented Feb 6, 2024

Normally lyrics should not get removed if they already have some.
But if wrong lyrics get added and there is no replacement, it should be possible to remove them at any time.
So, the parent entry lyrics should not reappear on the child entry after removing them from it (child entry).

Perhaps there could be a button on the lyrics tab to add the parent entry lyrics.

The issue is that the lyrics appear empty on children entries when in edit mode. The feature only works externally. That is also why a revert does not work on children entries.

@andreoda andreoda added content: lyrics Song lyrics entry-history/versioning Related to version history of entries/Edit history entry-activity Entry activities/changes to entries, Entry reports adding/editing entries Adding/Editing entries (artists, songs, albums, tags, song lists, events) labels Feb 6, 2024
@saturclay
Copy link
Contributor Author

saturclay commented Feb 6, 2024

Yeah, I think a "use parent version's lyrics" button on the child version's edit page would be good.

I don't know how often this specific situation will come up (i.e. parent version already has correct lyrics->someone adds incorrect lyrics to child version->incorrect lyrics are removed), but would be good to have the option.

@andreoda andreoda added priority: low Issues/Tasks that are not so important content: songs Song entries complexity: unknown Unknown days of work and removed entry-history/versioning Related to version history of entries/Edit history labels Mar 6, 2024
@Shiroizu Shiroizu added the bug/error Bugs and errors (timeout) label Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adding/editing entries Adding/Editing entries (artists, songs, albums, tags, song lists, events) bug/error Bugs and errors (timeout) complexity: unknown Unknown days of work content: lyrics Song lyrics content: songs Song entries entry-activity Entry activities/changes to entries, Entry reports priority: low Issues/Tasks that are not so important
Projects
Development

No branches or pull requests

3 participants