fixup cython api and optimize MultiDictIter_New #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also need to figure out what is wrong with 3.14 ext builds I have uv virtual enviornment open with 3.14t and it runs just fine locally. Not sure why the workflows for 3.14 are breaking? |
|
I'll match up the workflow I'll be back in half an hour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to start by making changes in a separate Pull request outside of the main pull request to try and keep the commit history a little bit tighter. aio-libs#1190 while I wait for conformation or another code review.
If anyone wants to review this Pull request going to my own branch you have every right to do so. I will allow up to a couple of days before I do any merges unless a reviewer wants to come in and review my changes into my own branch.