Skip to content

Commit fe6d85f

Browse files
authored
Merge pull request #9 from Visual-Regression-Tracker/46-diffTolerance-default-fix
diffTollerancePercent default is taken if undefined
2 parents a11fa5a + fd02bfe commit fe6d85f

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/test-runs/test-runs.service.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ describe('TestRunsService', () => {
165165
browser: 'browser',
166166
viewport: 'viewport',
167167
device: 'device',
168-
diffTollerancePercent: 1,
168+
diffTollerancePercent: undefined,
169169
};
170170
const testRunWithResult = {
171171
id: 'id',
@@ -228,7 +228,7 @@ describe('TestRunsService', () => {
228228
expect(service.getDiff).toHaveBeenCalledWith(
229229
baseline,
230230
image,
231-
createTestRequestDto.diffTollerancePercent,
231+
testRun.diffTollerancePercent,
232232
testVariation.ignoreAreas
233233
);
234234
expect(getImageMock).toHaveBeenNthCalledWith(1, testVariation.baselineName);

src/test-runs/test-runs.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ export class TestRunsService {
136136
const diffResult = this.getDiff(
137137
baseline,
138138
image,
139-
createTestRequestDto.diffTollerancePercent,
139+
testRun.diffTollerancePercent,
140140
testVariation.ignoreAreas
141141
);
142142

0 commit comments

Comments
 (0)