fix: update VennSeries to handle empty keys and filter valid legend keys #4000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
#2847
🔗 Related PR link
VisActor/VUtil#239
🐞 Bugserver case id
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
This pull request refines the logic for handling selected keys in the
VennSeries
class to improve filtering and ensure proper handling of empty keys. The most important changes focus on enhancing the filtering process and maintaining consistency in the selected keys array.Improvements to key filtering and handling:
emptyKey
constant and added logic to check for and handle empty keys (''
) in theselectedKeys
array. This ensures that empty keys are preserved when appropriate.selectedKeys
array and using only valid keys fromoriginalLegendKeys
for further operations. This avoids processing invalid or empty keys.selectedKeys
array to operate on the filterednonEmpty
keys, improving clarity and correctness.🔍 Walkthrough
copilot:walkthrough