Skip to content

fix(word-cloud): improve animation config handling and add max #3938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

eleliauk
Copy link

@eleliauk eleliauk commented May 6, 2025

[中文版模板 / Chinese template]

🤔 This is a Bug fix

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Release
  • Site / documentation update
  • Demo update
  • Workflow
  • Other (about what?)

🔗 Related issue link

🔗 Related PR link

🐞 Bugserver case id

💡 Background and solution

这面发现是没加这个属性
然后base.ts 里面还有一个any类型的error 也修复了一下

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@github-actions github-actions bot added the vchart label May 6, 2025
@xuefei1313 xuefei1313 requested a review from xiaoluoHe May 13, 2025 03:34
@@ -420,6 +423,7 @@ export class BaseWordCloudSeries<T extends IBaseWordCloudSeriesSpec = IBaseWordC
shrink: this._wordCloudConfig.zoomToFit.shrink,
enlarge: this._wordCloudConfig.zoomToFit.enlarge,
minFontSize: this._wordCloudConfig.zoomToFit.fontSizeLimitMin,
maxFontSize: this._wordCloudConfig.zoomToFit.fontSizeLimitMax,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

底层没有支持这个配置,需要在算法层支持该配置

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] wordcloud fontSizeLimitMax not work
2 participants