Skip to content

Bloop's JVM version too low will not fail the compilation #3116

Open
@MaciejG604

Description

@MaciejG604

After merging #3112, Bloop will no longer fail when compiling with required jvm version higher than the version it's running on. The outline of the problem is:

The test with correct bloop JVM version is a weird case since in old behaviour we never send java-19 path to bloop before the workspace reload. So we were sending java-11 and the --release 19 resulted in an error during compilation. New behaviour is we send java-19 path and the compilation succeeds, but we get some error logs from bloop from whetever it's doing with the compiler jar 🤷.

This won't affect Metals users as I think, we get a workspace reload everytime project configuration changes. However for IJ user this might be confusing.

Potential workaround:

  • On every 'prepareBuild()' check if bloop's jvm version is too low and restart Bloop - this will requires either ugly code or a bigger refactor
  • On every 'prepareBuild()' check if bloop's jvm version is too low and fail the build process with a readable diagnostic for the user - this should be much easier

Metadata

Metadata

Assignees

No one assigned

    Labels

    BloopIssues tied with Bloop integration.bugSomething isn't workinggood first issueGood for newcomersjvmIssues tied to the JVM platform

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions