Skip to content

Commit 1fb78ff

Browse files
authored
Merge pull request #3671 from Gedochao/update/scala-3.3.6
Bump Scala 3 LTS to 3.3.6
2 parents 17ba2fa + e58742e commit 1fb78ff

File tree

4 files changed

+22
-19
lines changed

4 files changed

+22
-19
lines changed

.github/release/release-procedure.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,13 @@
2424
- [ ] Wait for the `Update dist` PR to be automatically created after the previous one has been merged, and then
2525
proceed to merge it.
2626
- [ ] Make a release with the updated Scala CLI version.
27-
- [ ] Update the `v1` & `v1.7` tags to the latest release commit.
27+
- [ ] Update the `v1` & `v1.8` tags to the latest release commit.
2828
```bash
2929
git fetch --all
30-
git checkout origin v1.7.x
31-
git tag -d v1.7
32-
git tag v1.7
33-
git push origin v1.7 -f
30+
git checkout origin v1.8.x
31+
git tag -d v1.8
32+
git tag v1.8
33+
git push origin v1.8 -f
3434
git tag -d v1
3535
git tag v1
3636
git push origin v1 -f

modules/cli/src/main/scala/scala/cli/commands/repl/Repl.scala

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -75,18 +75,18 @@ object Repl extends ScalaCommand[ReplOptions] with BuildCommandHelpers {
7575
val maybeDowngradedScalaVersion = {
7676
val isDefaultAmmonite = ammonite.contains(true) && ammoniteVersionOpt.isEmpty
7777
extension (s: MaybeScalaVersion)
78-
private def isLts: Boolean = s.versionOpt
79-
.exists(v =>
80-
v.startsWith(Constants.scala3LtsPrefix) ||
81-
ScalaVersionUtil.scala3Lts.contains(v.toLowerCase)
82-
)
78+
private def isLtsAlias: Boolean =
79+
s.versionOpt.exists(v => ScalaVersionUtil.scala3Lts.contains(v.toLowerCase))
80+
private def isLts: Boolean =
81+
s.versionOpt.exists(_.startsWith(Constants.scala3LtsPrefix)) || isLtsAlias
8382
baseOptions.scalaOptions.scalaVersion match
8483
case Some(s)
85-
if isDefaultAmmonite && s.isLts && s.versionOpt
86-
.exists(_.coursierVersion > maxAmmoniteScalaLtsVer.coursierVersion) =>
87-
logger.message(
88-
s"Scala ${s.versionOpt.getOrElse(Constants.scala3Lts)} is not yet supported with this version of Ammonite"
89-
)
84+
if isDefaultAmmonite && s.isLts &&
85+
(s.versionOpt
86+
.exists(_.coursierVersion > maxAmmoniteScalaLtsVer.coursierVersion) ||
87+
s.isLtsAlias) =>
88+
val versionString = s.versionOpt.filter(_ => !s.isLtsAlias).getOrElse(Constants.scala3Lts)
89+
logger.message(s"Scala $versionString is not yet supported with this version of Ammonite")
9090
logger.message(s"Defaulting to Scala $maxAmmoniteScalaLtsVer")
9191
Some(MaybeScalaVersion(maxAmmoniteScalaLtsVer))
9292
case None

project/deps.sc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ object Scala {
1010
def scala212 = "2.12.20"
1111
def scala213 = "2.13.16"
1212
def scala3LtsPrefix = "3.3" // used for the LTS version tags
13-
def scala3Lts = s"$scala3LtsPrefix.5" // the LTS version currently used in the build
13+
def scala3Lts = s"$scala3LtsPrefix.6" // the LTS version currently used in the build
1414
def runnerScala3 = scala3Lts
1515
def scala3NextPrefix = "3.7"
1616
def scala3Next = s"$scala3NextPrefix.0" // the newest/next version of Scala
@@ -74,7 +74,7 @@ object Scala {
7474
def maxAmmoniteScala212Version = scala212
7575
def maxAmmoniteScala213Version = scala213
7676
def maxAmmoniteScala3Version = "3.6.3"
77-
def maxAmmoniteScala3LtsVersion = scala3Lts
77+
def maxAmmoniteScala3LtsVersion = "3.3.5"
7878
lazy val listMaxAmmoniteScalaVersion =
7979
Seq(maxAmmoniteScala212Version, maxAmmoniteScala213Version, maxAmmoniteScala3Version)
8080
lazy val listAllAmmonite = {

website/docs/release_notes.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,17 @@ import ReactPlayer from 'react-player'
1010

1111
## [v1.8.0](https://github.com/VirtusLab/scala-cli/releases/tag/v1.8.0)
1212

13-
### Support for Scala 3.7.0
13+
### Support for Scala 3.7.0 and 3.3.6
1414
This Scala CLI version switches the default Scala version to 3.7.0.
15+
The CLI internals are now built with Scala 3.3.6.
1516

1617
```bash
1718
scala-cli version
1819
# Scala CLI version: 1.8.0
1920
# Scala version (default): 3.7.0
2021
```
2122

22-
Added by [@Gedochao](https://github.com/Gedochao) in [#3661](https://github.com/VirtusLab/scala-cli/pull/3661)
23+
Added by [@Gedochao](https://github.com/Gedochao) in [#3661](https://github.com/VirtusLab/scala-cli/pull/3661) and [#3671](https://github.com/VirtusLab/scala-cli/pull/3671)
2324

2425
### Support for Scala.js 1.19.0
2526
This Scala CLI version adds support for Scala.js 1.19.0.
@@ -188,6 +189,8 @@ Added by [@Gedochao](https://github.com/Gedochao) in [#3653](https://github.com/
188189
* Bump Scala 3 Next RC to 3.7.1-RC1 by [@Gedochao](https://github.com/Gedochao) in [#3663](https://github.com/VirtusLab/scala-cli/pull/3663)
189190
* Update `runner` & `test-runner` to Scala 3.3.5 LTS (was 3.0.2) by [@Gedochao](https://github.com/Gedochao) in [#3650](https://github.com/VirtusLab/scala-cli/pull/3650)
190191
* Update `scalafmt` to 3.9.6 by [@scala-steward](https://github.com/scala-steward) in [#3667](https://github.com/VirtusLab/scala-cli/pull/3667)
192+
* chore: Bump Bloop to 2.0.10 by [@tgodzik](https://github.com/tgodzik) in [#3670](https://github.com/VirtusLab/scala-cli/pull/3670)
193+
* Bump Scala 3 LTS to 3.3.6 by [@Gedochao](https://github.com/Gedochao) in [#3671](https://github.com/VirtusLab/scala-cli/pull/3671)
191194

192195
**Full Changelog**: https://github.com/VirtusLab/scala-cli/compare/v1.7.1...v1.8.0
193196

0 commit comments

Comments
 (0)