Skip to content

Commit 8d41f3e

Browse files
Update action to use node 20 (#457)
Also updates CI node versions and [tsconfig target](https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping)
1 parent 3d727be commit 8d41f3e

File tree

8 files changed

+360
-160
lines changed

8 files changed

+360
-160
lines changed

.eslintrc.json

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
11
{
2-
"plugins": [
3-
"@typescript-eslint"
4-
],
2+
"plugins": ["@typescript-eslint"],
53
"extends": [
6-
"plugin:github/recommended"
4+
"plugin:github/typescript"
75
],
86
"parser": "@typescript-eslint/parser",
97
"parserOptions": {
108
"ecmaVersion": 9,
119
"sourceType": "module",
12-
"project": "./tsconfig.json"
10+
"project": true
1311
},
1412
"rules": {
1513
"eslint-comments/no-use": "off",
@@ -34,10 +32,7 @@
3432
"allowExpressions": true
3533
}
3634
],
37-
"@typescript-eslint/func-call-spacing": [
38-
"error",
39-
"never"
40-
],
35+
"@typescript-eslint/func-call-spacing": ["error", "never"],
4136
"@typescript-eslint/no-array-constructor": "error",
4237
"@typescript-eslint/no-empty-interface": "error",
4338
"@typescript-eslint/no-explicit-any": "warn",
@@ -59,10 +54,7 @@
5954
"@typescript-eslint/require-array-sort-compare": "error",
6055
"@typescript-eslint/restrict-plus-operands": "error",
6156
"semi": "off",
62-
"@typescript-eslint/semi": [
63-
"error",
64-
"never"
65-
],
57+
"@typescript-eslint/semi": ["error", "never"],
6658
"@typescript-eslint/type-annotation-spacing": "error",
6759
"@typescript-eslint/unbound-method": "error",
6860
"i18n-text/no-en": "off"

.github/workflows/test.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,15 @@ jobs:
1919
steps:
2020
- uses: actions/checkout@v4
2121

22+
- name: Setup Node.js
23+
uses: actions/setup-node@v2
24+
with:
25+
node-version: '20'
26+
cache: 'npm'
2227
- name: Build
2328
shell: bash -l {0}
2429
run: |
25-
nvm install lts/gallium
26-
nvm use lts/gallium
27-
npm install
30+
npm ci
2831
npm run all
2932
3033
# create an sbt file to enabling sbt caching

.github/workflows/update-dist.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,15 @@ jobs:
1111
- uses: actions/checkout@v4
1212
with:
1313
ssh-key: ${{ secrets.SCALA_CLI_SETUP_INTERNAL_KEY }}
14+
- name: Setup Node.js
15+
uses: actions/setup-node@v2
16+
with:
17+
node-version: '20'
18+
cache: 'npm'
1419
- name: Build
1520
shell: bash -l {0}
1621
run: |
17-
nvm install lts/gallium
18-
nvm use lts/gallium
19-
npm install
22+
npm ci
2023
npm run all
2124
2225
- name: Create Pull Request

action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,5 +30,5 @@ outputs:
3030
scala-cli-version:
3131
description: 'Version of the installed Scala CLI'
3232
runs:
33-
using: 'node16'
33+
using: 'node20'
3434
main: 'dist/index.js'

0 commit comments

Comments
 (0)