Land mass #322
Open
Land mass #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created new example ClimateLand to show differences between these choices. Still testing. Random may be OK, but polar and equatorial appear to be broken.
…nd the code appears to be working.
…tion of latitude.
…9.2% of their surface area covered in land.
Test Results19 667 tests 19 667 ✅ 1m 34s ⏱️ Results for commit e70b0a8. ♻️ This comment has been updated with latest results. |
…sitional latitudes. Modern geography is still broken.
…dFracGlobal, but the mods didn't change the result.
Also temporarily set units to the following outputs to non-dimensional to enable testing: - AreaIceCov - IceMass - IceAblate - PlackBAvg - IceAccum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe your changes here to communicate to the maintainers the value of this pull request (PR). If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your PR introduce to VPLanet?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of the steps that are necessary before merging your PR.Further comments
If this is a relatively large or complex change, explain why you chose the solution you did, what alternatives you considered, or anything else you believe to be relevant.