Bug fixed that calculates sampling of Gaussian source in Circular or … #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Ellipsoid Source. Location of (x,y) in source was determined by beamDiamFwhm, but should have been determined by the distance from the center of the circle or ellipsoid, i.e. (beamDiamFwhm/2). Updated code, unit test validation code MATLAB scripts and unit C# code. All unit tests currently pass.
…TextReader to System.IO.StreamReader for improved performance.
…ce-calculation-bug
Member
Author
|
I fixed SonarQubeCloud issue and also merged in main. |
|
janakarana
approved these changes
Sep 4, 2025
Member
janakarana
left a comment
janakarana
left a comment
There was a problem hiding this comment.
@hayakawa16
Looks good. Thanks for doing this fix.
Member
Author
|
Thank you for reviewing it @janakarana! |
Member
Author
|
Thank you @lmalenfant! |
hayakawa16
deleted the
bug/204-monte-carlo-circular-gaussian-source-calculation-bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Ellipsoid Source. Location of (x,y) in source was determined by beamDiamFwhm, but should have been determined by the distance from the center of the circle or ellipsoid, i.e. (beamDiamFwhm/2). Updated code, unit test validation code MATLAB scripts and unit C# code. All unit tests currently pass.