Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for complex logic in line author feature #322

Open
GollyTicker opened this issue Sep 25, 2022 · 0 comments
Open

Tests for complex logic in line author feature #322

GollyTicker opened this issue Sep 25, 2022 · 0 comments

Comments

@GollyTicker
Copy link
Contributor

GollyTicker commented Sep 25, 2022

The line author feature #288 contains complex logic at a few places. It would be nice to have proper testing for them to improve the sustainability of the code.

Most important places:

  • time difference computations (including time-zones)
  • git blame parsing
  • rendering of commits to DOM based on settings
    • this can be done by directly calling the toDOM function instead of using UI-based testing
  • adaptive coloring computation
  • continues to work in submodules
  • continues to work, when vault-root != git-repository-root

We also want to document how to use the test-vault to manually test some specific edge cases when significant changes have been made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant