From fea6bb84a6db99ffa6d70a0a4954bef398ae6ee8 Mon Sep 17 00:00:00 2001 From: Marc Khouzam Date: Sun, 19 May 2019 15:54:23 -0400 Subject: [PATCH] (helm): update Cobra to version 0.0.4 The version of Cobra used in dev-v3 is older than the one used for the master branch (helm v2). Although the dev-v3 branch was based on master and therefore had the same Cobra version originally, it was changed a couple of times to choose Cobra tagged versions instead. However, the currently used 0.0.3 version of Cobra is older than the version of Cobra used on the master branch. Therefore, some of the improvements made to Cobra and used by helm v2 are not available to helm v3 currently. This commit brings Cobra to its latest available version of 0.0.4. Bringing Cobra up-to-date is essential for upcoming work being prepared for dynamic bash-completion; there are bug fixes in Cobra that are necessary for dynamic bash-completion to work properly. Specifically, spf13/cobra#730 which fixes spf13/cobra#694 is essential to avoid the risk of colliding and possibly breaking kubectl dynamic bash-completion once helm v3 has its own dynamic completion. Signed-off-by: Marc Khouzam --- Gopkg.lock | 6 +++--- Gopkg.toml | 4 ++++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/Gopkg.lock b/Gopkg.lock index 9b02085efc5..81ea186ea40 100644 --- a/Gopkg.lock +++ b/Gopkg.lock @@ -879,15 +879,15 @@ version = "v1.4.1" [[projects]] - digest = "1:e01b05ba901239c783dfe56450bcde607fc858908529868259c9a8765dc176d0" + digest = "1:2e72f9cdc8b6f94a145fa1c97e305e1654d40507d04d2fbb0c37bf461a4b85f7" name = "github.com/spf13/cobra" packages = [ ".", "doc", ] pruneopts = "UT" - revision = "ef82de70bb3f60c65fb8eebacbb2d122ef517385" - version = "v0.0.3" + revision = "67fc4837d267bc9bfd6e47f77783fcc3dffc68de" + version = "v0.0.4" [[projects]] digest = "1:c1b1102241e7f645bc8e0c22ae352e8f0dc6484b6cb4d132fa9f24174e0119e2" diff --git a/Gopkg.toml b/Gopkg.toml index 26daeee8a58..7490732f6c9 100644 --- a/Gopkg.toml +++ b/Gopkg.toml @@ -109,3 +109,7 @@ [[constraint]] name = "github.com/xeipuuv/gojsonschema" version = "1.1.0" + +[[constraint]] + name = "github.com/spf13/cobra" + version = "0.0.4"