sample solution for supplying attributes to content areas #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ping @jonspalmer @rosendi @thomasbrus |
muan
reviewed
May 1, 2020
Contributor
|
I'm a little confused about how this implementation solves the original problem in #285. This doesn't look like it allows arguments to be passed into the content areas. Instead it's provide a way to decorate those areas with other static properties. I don't think that's the same thing. |
Co-authored-by: Mu-An 慕安 <muan@github.com>
Member
|
Thanks for doing this spike @andrewmcodes! We're going pursue a different approach to this change ❤️ |
Contributor
Author
|
@joelhawksley sounds good! Sorry this change slipped off my radar due to some personal events but I am excited to see what everyone came up with! Thanks for working on this with me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Example solution for supplying attributes to content areas
Related Issues #285
Other Information
Results of pairing with @joelhawksley