Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further development on the Margin Trading API #226

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

acravenho
Copy link

Added the following endpoints:

  • margin trading order history
  • transfer
  • borrow (loan)
  • max borrow
  • repay
  • repay history
  • margin order history
  • margin assets
  • max transferable

Copy link
Member

@balthazar balthazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind only pushing the new margin endpoint rather than style changes that conflict with my prettier config?

@bennycode
Copy link
Contributor

@acravenho can you allow maintainers to edit your PR? This would help us adjusting the Prettier styling and merging your PR.

@acravenho
Copy link
Author

@bennyn No problem at all. Sorry, I've been super busy.

@bennycode
Copy link
Contributor

@balthazar
Copy link
Member

@bennyn I do not, but you could fork his branch and submit a new PR with your updates, so you don't have to wait on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants