Skip to content

Conversation

@Sommos
Copy link
Contributor

@Sommos Sommos commented Aug 21, 2023

Modified

  • Refactored all filter files to keep inline with C style guide
  • Moved GTK+4.0 UI elements over to gtk_gui.c from Main.c

@Sommos Sommos added the Refactoring Improvement to Code label Aug 21, 2023
@Sommos Sommos added this to the Refactoring milestone Aug 21, 2023
@Sommos Sommos requested review from a team and VerzatileDev August 21, 2023 22:50
@Sommos Sommos added bug Something isn't working documentation Improvements or additions to documentation labels Aug 21, 2023
Copy link
Contributor

@VerzatileDev VerzatileDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few possible renaming warnings, other than that code looks to be good and stable.
Please take a note at the comments before merge.

Copy link
Contributor

@VerzatileDev VerzatileDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.vscode was also included within the commit, make sure to get rid of it if possible as we talked about previously.

@VerzatileDev
Copy link
Contributor

Bug #9 [BUG] - Application Crash After scaling. Present with the following Commit.

@VerzatileDev VerzatileDev changed the title refactored filters, GTK GUI refactored filters (All), GTK GUI Aug 22, 2023
@Sommos
Copy link
Contributor Author

Sommos commented Aug 22, 2023

Bug #9 [BUG] - Application Crash After scaling.
This is now resolved.

@Sommos Sommos merged commit 899e9e6 into VerzatileDevOrg:main Aug 22, 2023
@Sommos Sommos changed the title refactored filters (All), GTK GUI Refactored filters (All), GTK GUI Aug 23, 2023
@Sommos Sommos changed the title Refactored filters (All), GTK GUI Refactored Filters (All), GTK+4.0 UI Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation Refactoring Improvement to Code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants